Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)

src/core/backend/avx512/fft.rs line 197 at r1 (raw file):

    //    fft on b
    //   a:bcid
    //    fft on a

Done.

src/core/backend/avx512/fft.rs line 213 at r1 (raw file):

    //   0 1 2 3 4 5 6 7 0 1 2 3 4 5 6 7
    let t = _mm512_broadcast_i64x4(std::mem::transmute(twiddle1_dbl));
    //   Apply i:abcd => d:iabc

Done.

src/core/backend/avx512/fft.rs line 232 at r1 (raw file):

Done.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware)

src/core/backend/avx512/fft.rs line 179 at r2 (raw file):

Done.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

src/core/backend/avx512/fft.rs line 179 at r2 (raw file):

not pushed

src/core/backend/avx512/fft.rs line 200 at r2 (raw file):

    // The twiddles for layer 2 are packed like:
    //   0 1 2 3 0 1 2 3 0 1 2 3 0 1 2 3

Suggestion:

    // The twiddles for layer 2 are replicated in the following pattern:
    //   0 1 2 3 0 1 2 3 0 1 2 3 0 1 2 3

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

src/core/backend/avx512/fft.rs line 179 at r2 (raw file):

Done.

src/core/backend/avx512/fft.rs line 200 at r2 (raw file):

    // The twiddles for layer 2 are packed like:
    //   0 1 2 3 0 1 2 3 0 1 2 3 0 1 2 3

Done.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)